Skip to content
This repository has been archived by the owner on Jun 7, 2020. It is now read-only.

[WIP] [NEW] Project 03 - Changing, searching and adding channels VoiceOver accessible #2751

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

rudrankriyam
Copy link
Contributor

@rudrankriyam rudrankriyam commented Aug 19, 2019

@RocketChat/ios

  • Clicking on a room reads the WHOLE message, instead of an excerpt of the message.
  • Sorting by activity needs a hint regarding double tapping to open the options.
  • “New Channel” Button is not accessible. It is described in VoiceOver as a “Button” and should have an accessibilityLabel = “Create New Channel”
  • “Public Channel” and “Read only channel” text field and the switch toggle should be read as one.
  • After creating a channel, VoiceOver describes the button as “Create Dim”, which should be labelled as “Channel created successfully.” Edit - Create Dim means that it is in working state. After the channel is created, it goes to the channel itself.
  • The cross button is described in VoiceOver as “Stop” button, which needs to be named as “Close” button.
  • “Share” button needs to be associated with UIAccessibilityTraits.button.
  • “Favorite” button is not accessible. It is described in VoiceOver as a “Button” and should have an accessibilityLabel = “Star”
  • The “Video Call” button is not accessible. It is described in VoiceOver as “User.Detail Video Call”, which should have an accessibilityLabel = “Video Call”.
  • Receive Notification and Show Unread Counter text field and the switch toggle should be read as one.
  • The VoiceOver should describe the cell as one unit, instead of two different accessibility elements.

@rudrankriyam rudrankriyam changed the title [WIP] [NEW] Project03 Changing, searching and adding channels [WIP] [NEW] Project 03 - Changing, searching and adding channels Aug 19, 2019
@rudrankriyam rudrankriyam changed the title [WIP] [NEW] Project 03 - Changing, searching and adding channels [WIP] [NEW] Project 03 - Changing, searching and adding channels VoiceOver accessible Aug 19, 2019
@codecov
Copy link

codecov bot commented Aug 19, 2019

Codecov Report

Merging #2751 into develop will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2751      +/-   ##
===========================================
- Coverage     46.1%   46.07%   -0.04%     
===========================================
  Files          626      626              
  Lines        28938    28958      +20     
===========================================
- Hits         13343    13341       -2     
- Misses       15595    15617      +22
Impacted Files Coverage Δ
...t/Views/Subscriptions/SubscriptionsTitleView.swift 41.66% <ø> (-3.08%) ⬇️
...at/Views/Cells/Subscription/SubscriptionCell.swift 0% <0%> (ø) ⬆️
...ontrollers/Chat/ChannelActionsViewController.swift 0% <0%> (ø) ⬆️
...iews/Cells/Subscription/BaseSubscriptionCell.swift 0% <0%> (ø) ⬆️
...trollers/Subscriptions/NewRoomViewController.swift 19.56% <0%> (-0.29%) ⬇️
...ubscriptionsList/SubscriptionsViewController.swift 1.41% <0%> (-0.01%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2f5ad00...c690c33. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant